added index.html to MATLAB capstone bioeng lesson

swcarpentry / matlab-novice-capstone-biomed

Short lesson on biomedical engineering.

Other

6 stars 4 forks source link

added index.html to MATLAB capstone bioeng lesson #3

Closed IsaKiko closed 9 years ago

IsaKiko commented 9 years ago

added index.html

wking commented 9 years ago

On Mon, Apr 20, 2015 at 04:05:40PM -0700, Isabell Kiral-Kornek wrote:

added index.html

This looks pretty good to me.

Minor style suggestions to the index.md source:

“software carpentry” → “Software Carpentry”.
“loading .mat-files” → “loading .mat-files”.
“in MATLAB software carpentry lesson” → “in a MATLAB Software Carpentry lesson”.

You might also want to rename the topic to 01-capstone.md or some such to get the recommended numeric prefix (dd-slug.md in the docs 1).

IsaKiko commented 9 years ago

Thanks for having a look at this! Feedback incorporated.

wking commented 9 years ago

On Mon, Apr 20, 2015 at 04:23:50PM -0700, Isabell Kiral-Kornek wrote:

Thanks for having a look at this!

No problem :).

And I was suggesting backticks around .mat (so “.mat”, not “.'mat'”) to get “.mat-files” in the Markdown-expanded HTML.

IsaKiko commented 9 years ago

Ah, thank you! Fixed.

wking commented 9 years ago

On Mon, Apr 20, 2015 at 04:58:31PM -0700, Isabell Kiral-Kornek wrote:

Ah, thank you! Fixed.

Looks good to me, thanks :).

jiffyclub commented 9 years ago

Looks good to me. @IsaKiko, I'll let you resolve this and #4. Since this is a matlab lesson I've added this repo to the @swcarpentry/matlab-maintainers team so you and @ashwinsrnth can merge PRs here.