swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
164 stars 431 forks source link

edits to standardize the format of exercises #514

Closed eldobbins closed 3 years ago

eldobbins commented 3 years ago

This PR is to address issues described in #461, which describes an exercise whose formatting could be improved. While working on that exercise, I found a couple more with formatting oddities, so fixed them too.

I'm not satisfied with the wording of that last exercise. It asks 2 questions and then solves them before asking 2 more whose answers are in the Solutions block. I see that the exercise author is trying to chain concepts, but I'm not 100% sure it's successful. Please let me know if you want me to reformulate that exercise as part of this PR

alee commented 3 years ago

Reformulation of the exercise would be welcome, but we can have a separate PR for that - thanks again!

eldobbins commented 3 years ago

Maybe we could close the original issue #461 ?

eldobbins commented 3 years ago

I just checked the formatted rendering of the changes I made, and it's all screwed up. I'm going to try and fix that. I still have the branch. Can this PR be reopened or should I start a new one?

eldobbins commented 3 years ago

OK. I've fixed the formatting problems. The fixes are in the original branch. Please let me know how I should submit it.

eldobbins commented 3 years ago

Issued a new PR to fix this rendering problem.