swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
164 stars 431 forks source link

Challenges review #541

Closed vinisalazar closed 3 years ago

vinisalazar commented 3 years ago

Hi,

I'm reviewing the challenges for this lesson and making some minor improvements. Please let me know if I should create a separate issue to discuss this.

Episodes reviewed so far:

I hope these changes are helpful for the lesson.

Best wishes, V

vinisalazar commented 3 years ago

I'd greatly appreciate a careful review of d52dcd5.

vinisalazar commented 3 years ago

ping @alee @ntmoore @souravsingh @vahtras

I'm aware this is a fairly large PR, so please know that I'm available for discussing, editing, or justifying any of the changes made.

Thank you for any assistance you can provide.

Best, Vini

vinisalazar commented 3 years ago

Hello @alee, thank you for the reply.

I understand. I will keep that in mind for future contributions. Would you like me to break this up into separate PRs, one for each episode? Or may I leave it as is?

Best wishes, Vini

alee commented 3 years ago

Let's leave it as is as there is a considerable amount of work in here already, just wanted to point that out for future reference :+1:

I'll do my best to review this and get it merged in the next few days - thanks!

vinisalazar commented 3 years ago

Thank you @alee !

vinisalazar commented 3 years ago

@alee thank you for the thorough review. Hopefully I've addressed all requested changes.

Best, V