search

swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
163 stars 427 forks source link

Ep02 minor fixes/typos #570

Closed vinisalazar closed 2 years ago

vinisalazar commented 2 years ago

Hi,

Here are some minor fixes. If merged, this PR will:

Best, Vini

alex-ball commented 2 years ago

According to the Wikipedia link (and this is indeed how I remember it) mathematical interval notation uses a comma rather than a colon for separating the limits. To make it clearer that this isn't Python, perhaps it would be better to have [start, stop) or, even better, avoid the monospace and write it [start, stop).

vahtras commented 2 years ago

We also have that a mathematical interval [x, y) is more like a set of numbers and fundamentally different from a Python sequence of numbers where there is an implied order.

On Tue, Jan 4, 2022 at 11:02 AM Alex Ball @.***> wrote:

According to the Wikipedia link (and this is indeed how I remember it) mathematical interval notation uses a comma rather than a colon for separating the limits. To make it clearer that this isn't Python, perhaps it would be better to have [start, stop) or, even better, avoid the monospace and write it [start, stop).

— Reply to this email directly, view it on GitHub https://github.com/swcarpentry/python-novice-gapminder/pull/570#issuecomment-1004672259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLLJBOFK3ADZTJFY3YGXBTUULAVFANCNFSM5D3FQNDA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

alee commented 2 years ago

We also have that a mathematical interval [x, y) is more like a set of numbers and fundamentally different from a Python sequence of numbers where there is an implied order.

Based on this discussion I'm inclined to simply remove the entire statement as it seems to be muddying the waters more than clarifying anything 😅

thanks for the feedback!