search

swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
163 stars 428 forks source link

Remove unexplained augmented assignment operators from examples #589

Closed naclomi closed 2 years ago

naclomi commented 2 years ago

Resolves #582 per issue discussion.

I did leave one instance of += in the exercise in episode 18, since its point was to emphasize the value of readable rather than terse code and I feel that running into unfamiliar syntax in the wild is a pretty common experience with codebases that need refactoring. Happy to remove it for overall consistency, though.

vahtras commented 2 years ago

The changes are ok, but you should really have a dedicated development branch (not your gh-pages) with a descriptive name for which the pull request is done. Otherwise, if you later push an unrelated change to your gh-pages branch it will reopen this PR.

naclomi commented 2 years ago

See PR #590