search

swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
163 stars 428 forks source link

Fix for issue #612, fixed variable names in text and added clarifying… #613

Closed BBentleyDev closed 1 year ago

BBentleyDev commented 1 year ago

… wording

Instructions Thanks for contributing! :heart: If this contribution is for instructor training, please email the link to this contribution to instructor.training@carpentries.org so we can record your progress. You've completed your contribution step for instructor checkout by submitting this contribution! Keep in mind that **lesson maintainers are volunteers** and it may take them some time to respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org. You may delete these instructions from your comment. \- The Carpentries
vahtras commented 1 year ago

You are right about correcting variable names, but on first reading, I thought the rephrasing was confusing, but then I got it. How about adding "so its value does not automatically change, when variable_one changes."

BBentleyDev commented 1 year ago

Agreed, I've made the suggested change to the wording.