swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
163 stars 428 forks source link

Broken link #617

Closed linajandren closed 1 year ago

linajandren commented 1 year ago

The link for matplotlib.pyplot near the top of the page is broken. The link points to https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.html#module-matplotlib.pyplot but this gives me a page not found error. I'm not certain where the link should point, perhaps https://matplotlib.org/stable/tutorials/introductory/pyplot.html ?

alee commented 1 year ago

Thanks for letting us know! I think the link in Episode 9 (http://swcarpentry.github.io/python-novice-gapminder/09-plotting/index.html) used to go to a page like this: https://matplotlib.org/3.5.3/api/_as_gen/matplotlib.pyplot.html but I prefer your link as a more durable URL that provides a nicer overview of matplotlib as opposed to an API landing page 😅 .

We'd welcome a PR to correct the link in episode 9, it'd be good to adjust all of those similar links if possible. I counted at least 4 of them there from a cursory grep. That matplotlib page is linked twice, once early on in the summary and again when introducing plotting via pandas dataframes, probably that second one could go away..?

vhmcck commented 1 year ago

Hi @alee, I recently completed my Instructor Training and I am looking for issues that need to be fixed. Do you still need a hand with this? If I understand correctly, the PR would have updated links. Any other than the three discussed (matplotlib, tick_params, savefig)?

alee commented 1 year ago

Absolutely, I don't believe anyone else has put forward a PR or indicated they are up for working on this. Thanks @vhmcck !

vhmcck commented 1 year ago

Thanks, @alee! I will go through the links and update them as necessary. I will let you know when I have submitted the PR with these changes.

vhmcck commented 1 year ago

Hi @alee, Just submitted a PR with my attempt at the second draft. Let me know what you think!