Closed zkamvar closed 1 year ago
Hello maintainers, one thing I notice in The previewe version of the Lesson Design page (from _extras/design.md) is that there are episode links that are no longer valid (see the missing files listed in https://github.com/carpentries/lesson-transition/issues/77). I can go in and fix these, but I'm wondering if I should just leave these links alone given that the file is out of sync with the lesson and has not been updated in 3 years.
(Note: I just rebuilt the preview, so the link may not be active for another couple of minutes)
Thanks for catching that @zkamvar! I'd vote to leave those alone and we can address them in a separate issue / PR after the workbench transition, don't want to add to your burdens.
We are all set to transition this lesson tomorrow. I have fixed all the issues that were identified and you can see the preview here: https://fishtree-attempt.github.io/python-novice-gapminder/
The landing page has this include still sitting around, I assume it should be removed?
{% include gh_variables.html %}
Good catch! yes, if it's not gone by the time I do the transition today (which is to say I will remove it), it will need to be removed.
This lesson will be converted to use The Carpentries Workbench To prevent accidental reversion of the changes, we are temporarily revoking write access for all collaborators on this lesson:
If you no longer wish to have write access to this repository, you do not need to do anything further.
If you wish to regain write access, please re-clone the repository on your machine and
then comment here with I am ready for write access :rocket:
and the
admin maintainer of this repository will restore your permissions.
If you have any questions, please reply here and tag @zkamvar
The deed is done. The infrastructure takes a few minutes to bootstrap and cache the packages for the lesson build. Once the build is done, I will switch github pages to deploy from the gh-pages
branch and you will have your workbench lesson.
Thank you all for your enthusiasm and your patience!
The Workbench version is now live: https://swcarpentry.github.io/python-novice-gapminder/
In addition, here is map of commits that were changed during the transition
Thanks @zkamvar! Looks great. I've re-forked the repo and reset my local git repo to upstream/main
Are there any plans for Docker support to render content locally? I'd be happy to contribute to https://github.com/carpentries/workbench/issues/39 if help is still needed there, I'm pretty comfortable with Docker / docker compose / etc
I am ready for write access :rocket:
@alee, you now have regained write access 🎉
Are there any plans for Docker support to render content locally? I'd be happy to contribute to https://github.com/carpentries/workbench/issues/39 if help is still needed there, I'm pretty comfortable with Docker / docker compose / etc
Yes, there is still need for this. With the transition, my backlog is growing and I unfortunately do not have the capacity for exploring it until later this quarter.
I am ready for write access :rocket:
On Tue, May 2, 2023 at 11:00 PM Zhian N. Kamvar @.***> wrote:
@alee https://github.com/alee, you now have regained write access 🎉
Are there any plans for Docker support to render content locally? I'd be happy to contribute to carpentries/workbench#39 https://github.com/carpentries/workbench/issues/39 if help is still needed there, I'm pretty comfortable with Docker / docker compose / etc
Yes, there is still need for this. With the transition, my backlog is growing and I unfortunately do not have the capacity for exploring it until later this quarter.
— Reply to this email directly, view it on GitHub https://github.com/swcarpentry/python-novice-gapminder/issues/632#issuecomment-1532143644, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLLJBI6MJYDWCY32MC4L6LXEFYWLANCNFSM6AAAAAAXLMKBHI . You are receiving this because you were mentioned.Message ID: @.***>
@vahtras you now have write access!
I am ready for write access :rocket:
@souravsingh access granted!
I am ready for write access :rocket: Thanks
@martinosorb, access granted!
All maintainers on this lesson now have access!
@swcarpentry/python-novice-gapminder-maintainers
As I hope you are already aware, we are rolling out the new lesson infrastructure, The Carpentries Workbench, across all of The Carpentries official lessons in early May 2023. This means that all Data Carpentry, Library Carpentry, and Software Carpentry lesson repositories will be modified to adopt the new infrastructure in the coming days.
You can follow the transition of this lesson repository at https://github.com/carpentries/lesson-transition/issues/77.
The transition has already taken place for several lessons, and so far the process has been running quite smoothly. You should see the transition take place with minimal disruption, but there are a few things that it is important for Maintainers to be aware of.
Here is what you can expect to happen next:
I will reply here before and after the transition has taken place. If you have any questions in the meantime, please reach out to the Curriculum Team by tagging us here, e.g. @swcarpentry/core-team-curriculum.
If you would like to read more about the new lesson infrastructure and the modified repository structure you can expect post-transition, I recommend the Infrastructure episode of the Maintainer Onboarding curriculum and the Workbench Transition Guide, which includes a side-by-side comparison of various elements of the old and new infrastructures.