swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
162 stars 428 forks source link

Update 01-run-quit.md #639

Closed wgriffa closed 1 year ago

wgriffa commented 1 year ago

In the Kernels definition, The JupyterLab docs define kernels as “separate processes started by the server that run your code

Changed run to runs

Please delete this line and the text below before submitting your contribution.


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.


github-actions[bot] commented 1 year ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

mkcor commented 1 year ago

Dear all,

I believe that this is mistake, since the subject of the verb "run" here is plural ("separate processes"). The subject isn't "the server!" The kernels run "code in different programming languages and environments" (as repeated in the sentence which follows).

Therefore, I would recommend reverting this change.

/cc @tobyhodges

wgriffa commented 1 year ago

Hi Marianne, you are correct. 🙂

Sorry for the confusion.

Walter Griffatong (he/him) Applications Support Specialist Library Digital Systems and Initiatives

416 736-2100 ext. 22791 @.**@.> | library.yorku.cahttp://library.yorku.ca/

York University Libraries | York University Scott Library 4700 Keele Street Toronto ON, Canada M3J 1P3

[York University Logo]

Out of respect and care for library staff and for our community, York University Libraries have reduced in-person services until further notice. For updated information and details about our online and other services, see https://www.library.yorku.ca/web/covid-19-york-libraries-services-and-operations-update/.

We recognize that many Indigenous Nations have longstanding relationships with the territories upon which York University campuses are located that precede the establishment of York University. York University acknowledges its presence on the traditional territory of many Indigenous Nations. The area known as Tkaronto has been care taken by the Anishinabek Nation, the Haudenosaunee Confederacy, and the Huron-Wendat. It is now home to many First Nation, Inuit and Métis communities. We acknowledge the current treaty holders, the Mississaugas of the Credit First Nation. This territory is subject of the Dish with One Spoon Wampum Belt Covenant, an agreement to peaceably share and care for the Great Lakes region.

This electronic mail (e-mail), including any attachments, is intended only for the recipient(s) to whom it is addressed and may contain information that is privileged, confidential and/or exempt from disclosure. No waiver of privilege, confidentiality or any other protection is intended by virtue of its communication by the internet. Any unauthorized use, dissemination or copying is strictly prohibited. If you have received this e-mail in error, or are not named as a recipient, please immediately notify the sender and destroy all copies of it.


From: Marianne Corvellec @.> Sent: Friday, May 12, 2023 3:39 PM To: swcarpentry/python-novice-gapminder @.> Cc: Walter Griffatong @.>; Author @.> Subject: Re: [swcarpentry/python-novice-gapminder] Update 01-run-quit.md (PR #639)

Dear all,

I believe that this is mistake, since the subject of the verb "run" here is plural ("separate processes"). The subject isn't "the server!" The kernels run "code in different programming languages and environments" (as repeated in the sentence which follows).

Therefore, I would recommend reverting this change.

/cc @tobyhodgeshttps://github.com/tobyhodges

— Reply to this email directly, view it on GitHubhttps://github.com/swcarpentry/python-novice-gapminder/pull/639#issuecomment-1546201096, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLSKE4DCNCBLXOWWM4LGB3XF2GWVANCNFSM6AAAAAAX42LMZQ. You are receiving this because you authored the thread.Message ID: @.***>