Closed mkcor closed 1 year ago
This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.
It should be safe to Approve and Run the workflows that need maintainer approval.
Dear @mkcor thank you for the suggestion. I believe 'interactively' is the main point of that sentence. The mention 'in Jupyter' on the other hand is a little redundant, because the sentence before is introducing what happens when a Jupyter notebook is opened... I personally would leave it as it is, or if you have other ideas let us know.
Thanks! Your suggestion is perhaps more accurate but at the cost of being more verbose. A wise man once said: if there is a conflict between accuracy and clarity, clarity always wins. I would leave it as is too.
On Thu, May 18, 2023 at 3:45 PM Martino Sorbaro @.***> wrote:
Dear @mkcor https://github.com/mkcor I believe 'interactively' is the main point of that sentence. The mention 'in Jupyter' on the other hand is a little redundant, because the sentence before is introducing what happens when a Jupyter notebook is opened... I personally would leave it as it is, or if you have other ideas let us know.
— Reply to this email directly, view it on GitHub https://github.com/swcarpentry/python-novice-gapminder/pull/643#issuecomment-1553080677, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLLJBOZMCULGB7XQAHO4OLXGYRXRANCNFSM6AAAAAAX754MIE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Dear maintainers,
This is minor, but I found myself hesitating for a second while teaching this yesterday.
I suggest this slight change:
/cc @JohanMabille