swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
163 stars 429 forks source link

Update 01-run-quit.md #644

Closed wiessall closed 1 year ago

wiessall commented 1 year ago

Fixed typo of 'denominator'

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-644

The following changes were observed in the rendered markdown documents:

 01-run-quit.md | 2 +-
 md5sum.txt     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-05-17 14:10:00 +0000

martinosorb commented 1 year ago

Thank you for spotting that, @wiessall.

Not merging yet because I'm a new maintainer and I need to understand a couple of things. @swcarpentry/python-novice-gapminder-maintainers do you know what are these warnings given by Github Actions, such as [unknown div] col-md-6 (visible in "files changed")?

martinosorb commented 1 year ago

I've checked with Zhian and these warnings can be ignored. Merging! Thank you @wiessall for the contribution.

wiessall commented 1 year ago

Hey thanks for actually commenting on this! I'm just going through the lesson my first time to prepare teaching it atm.