swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
162 stars 428 forks source link

Broken link in CONTRIBUTING.md #648

Closed somet-code closed 1 year ago

somet-code commented 1 year ago

The "How to Contribute to an Open Source Project on GitHub" link in CONTRIBUTING.md is broken. Clicking on it leads to 404 - Page Not Found, where a different link is suggested. The suggested link appears to be what you want.

I'm new to using GitHub, and since this seems like an issue that might affect many CONTRIBUTING.md files, I wanted to bring it to your attention before trying to proceed. Thank you!

vahtras commented 1 year ago

Thanks! This likely affects all workshops. I believe that https://github.com/carpentries/workshop-template is the place to raise the issue to get the correct link in future workshops. It is a small thing to fix in existing workshops as well (series -> courses in the egghead link)

karenword commented 1 year ago

Tagging @zkamvar because I think the current best place for issues like this might actually be https://github.com/carpentries/workbench . Can you confirm?

zkamvar commented 1 year ago

Unfortunately the appropriate place is literally every repository 😩

The new URL to this is https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

The reason why this needs to go to every repository is because the CONTRIBUTING.md is a repository-specific file, not an infrastructure file. It describes how people should contribute to a particular lesson and the expectations from the maintainers.

It's not something new; this is something that has been an issue in our lessons for a long time (but mea culpa because I had updated the CONTRIBUTING before the transition: https://github.com/carpentries/workbench-template-md/pull/25 and https://github.com/carpentries/sandpaper/pull/428 and forgot to update that particular link). I will bring this to the Curriculum team to see if we can get communications about this out to the maintainers.

vahtras commented 1 year ago

Fixed the link in this repo