Open Simon-Stone opened 1 year ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-650
The following changes were observed in the rendered markdown documents:
09-plotting.md | 10 +++++++++-
md5sum.txt | 2 +-
2 files changed, 10 insertions(+), 2 deletions(-)
:stopwatch: Updated at 2024-03-17 08:41:02 +0000
It looks good to me but I'd like opinions from other maintainers before merging.
I think it's a good addition as well. Only thing a bit leery of is the caveat in the docs This is an experimental feature and may not work for some cases. It only checks the extents of ticklabels, axis labels, and titles.
if that's still true.
We could also consider changing the example code to use constrained layouts instead?
Fixes #638 by adding calls to
tight_layout
to the respective solution.