swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
162 stars 428 forks source link

628 explicit df names #654

Closed sjvrijn closed 11 months ago

sjvrijn commented 1 year ago

Fix #628

Episode 8:

Episode 16:

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-654

The following changes were observed in the rendered markdown documents:

 08-data-frames.md       |  8 ++++----
 16-writing-functions.md | 14 +++++++-------
 md5sum.txt              |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-07-24 18:17:26 +0000

martinosorb commented 11 months ago

Hi @sjvrijn, thanks for the PR. It looks good, but I have a comment: episode 07 uses data_oceania instead. I suggest we use data_europe etc. (or change the other one to oceania, but I like the first option better, personally).

sjvrijn commented 11 months ago

@martinosorb good point for consistency, I've updated my changes.

martinosorb commented 11 months ago

LGTM. Merging!