Closed sjvrijn closed 11 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-654
The following changes were observed in the rendered markdown documents:
08-data-frames.md | 8 ++++----
16-writing-functions.md | 14 +++++++-------
md5sum.txt | 4 ++--
3 files changed, 13 insertions(+), 13 deletions(-)
:stopwatch: Updated at 2023-07-24 18:17:26 +0000
Hi @sjvrijn, thanks for the PR. It looks good, but I have a comment: episode 07 uses data_oceania
instead. I suggest we use data_europe
etc. (or change the other one to oceania
, but I like the first option better, personally).
@martinosorb good point for consistency, I've updated my changes.
LGTM. Merging!
Fix #628
Episode 8:
df
toeurope
Episode 16:
df
toasia
for the first specific casedf
tocountries
in the function writing exercise, since the genericcontinent
is already used