Closed wgriffa closed 4 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-667
The following changes were observed in the rendered markdown documents:
14-looping-data-sets.md | 4 +++-
md5sum.txt | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
:stopwatch: Updated at 2023-10-17 12:27:20 +0000
Agreed, thanks for the PR!
If you run the original command, print(p.parent), print(p.stem), print(p.suffix)
The output is, data gapminder_gdp_africa .csv
(None, None, None)
The last line is confusing, "(None, None, None)"
You're essentially doing three separate print calls and then creating a tuple with their return values. The print function in Python doesn't return any meaningful value (it returns None), so when you group them together with commas, you're creating a tuple of their return values, which is (None, None, None).
To get a clean output like you see in the lessons, you have to write the print statement on three separate lines.
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
If any relevant discussions have taken place elsewhere, please provide links to these.