Closed Shivay-Shakti closed 4 months ago
This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.
It should be safe to Approve and Run the workflows that need maintainer approval.
Thanks for taking the time to submit this PR! @sborrego submit the PR right before this that also addresses this issue in a simpler way with less conditional checks so I think we will go with that one. I'm guessing you all caught this during a carpentries workshop?
Thanks again, we appreciate your contributions!
That's amazing, yes we found it during the workshop. Thanks, @sborrego and @alee for your pro-activeness!
Summary
This pull request updates the conditional logic used for assigning letter grades based on numerical scores.
Changes
Motivation
The previous logic incorrectly assigned a 'C' grade to any score above 70 and a 'B' grade for any score above 80, without upper bounds. This update corrects the grade assignment to reflect the standard grading scale.
Testing