search

swcarpentry / python-novice-gapminder

Plotting and Programming in Python
http://swcarpentry.github.io/python-novice-gapminder/
Other
162 stars 428 forks source link

Remove the use of <div> in episode 01 #677

Closed martinosorb closed 2 months ago

martinosorb commented 2 months ago

This is apparently needed for the lesson to be workable with Crowdin for internationalisation purposes (see this thread on Slack).

Please note that I can't, at the moment, check whether the version in this PR will actually work in Crowdin -- but the problem there is supposed to be about the use of \<div>.

What the PR does is to change the section on Markdown of the first episode to look like this: image

Also fixes a typo by which the level-2 header looked the same as the level-1 header.

github-actions[bot] commented 2 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-677

The following changes were observed in the rendered markdown documents:

 01-run-quit.md | 211 ++++++++++++++++-----------------------------------------
 md5sum.txt     |   2 +-
 2 files changed, 58 insertions(+), 155 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-04-13 20:16:11 +0000

alee commented 2 months ago

thanks @martinosorb ! I'm going to close this PR since it's originating from your main branch which will cause problems down the line (i.e., extraneous merge commits) if merged but I've cherry picked the work into #678

martinosorb commented 2 months ago

Thank you so much for the quick response and for the extra work!