Closed saiboxx closed 2 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-679
The following changes were observed in the rendered markdown documents:
11-lists.md | 50 +++++++++++++++++++++++++++++++++++++++-----------
md5sum.txt | 2 +-
2 files changed, 40 insertions(+), 12 deletions(-)
:stopwatch: Updated at 2024-04-19 06:57:52 +0000
Thank you for your suggestions. These are on a number of topics we would prefer to review separately. Please consider them separately and present them in the issue tracking system first before making a PR.
Includes and closes #618: Use pop() instead of del in the Lists lesson?
When working through the "Lists" episode I noticed potential for streamlining and isolating some proposed concepts.
extend
, I created a separate section for merging lists.Hi Carpentry Team,
As I went through the "Lists" episode, I noticed that some programming concepts are mixed or truncated in the material.
First, the section about append introduces the concepts of lists merging via
extend
and also the possibility of nested lists. I extracted the existing part ofextend
under the general umbrella of merging lists, as I think the episode would benefit from this logical separation. Additionally, I introduce list merging via the+
operator, which is the pythonic way, often used in practice.I moved the discussion of lists being able to have lists as items into the fitting section about mixing data types. As lists are just a data type, the possibility of lists having lists as members is just a logical conclusion.
Lastly, I tried to generalize the section about using del to remove items.
del
is not the only option to remove list elements andpop
is also an essential element. This was also discussed in #618. I incorporatedpop
into the existing example withdel
.I would be happy for feedback. This is my first issue in this repository, so please have mercy if I have overlooked some guidelines. :)
Cheers, Tobias