swcarpentry / python-novice-inflammation

Programming with Python
http://swcarpentry.github.io/python-novice-inflammation/
Other
303 stars 781 forks source link

adding labels to plot #1079

Open jensbri opened 7 months ago

jensbri commented 7 months ago

While I understand the beauty of having just 3 lines of code to ingest a dataset and output a heatmap, the resulting plot does not meet the basic requirements of an adequate plot. We shouldn't teach people to generate something 'data-sciency' that people can re-use without understanding what is to be seen on the plot.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 7 months ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

jensbri commented 7 months ago

Kia ora.

Please find the output image below: DataLabels