search

swcarpentry / r-novice-gapminder

R for Reproducible Scientific Analysis
http://swcarpentry.github.io/r-novice-gapminder/
Other
164 stars 538 forks source link

Remove code that is not needed #873

Closed SarithaKodikara closed 11 months ago

SarithaKodikara commented 12 months ago

How could the content be improved?

In the episode exploring data frames (https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html), renaming row names is unnecessary as R re-names them sequentially. So, in the section 'Append to a data frame', the following code snippet can be removed.

rownames(cats) <- NULL
cats

Which part of the content does your suggestion apply to?

https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html

matthieu-bruneaux commented 11 months ago

Thank you for noticing this @SarithaKodikara!

If you would like to submit a PR addressing this, I would be happy to review and merge it.

matthieu-bruneaux commented 11 months ago

Thank you for your PR and for helping us to keep the lesson up to date @SarithaKodikara!