search

swcarpentry / r-novice-gapminder

R for Reproducible Scientific Analysis
http://swcarpentry.github.io/r-novice-gapminder/
Other
164 stars 538 forks source link

Remove plyr episode and update episode numbering #885

Closed milanmlft closed 6 months ago

milanmlft commented 8 months ago

Fixes #540

Removes the plyr episode as it has become obsolete and plyr has been retired. I also updated the version of igraph in the package cache, as the older version was giving installation errors when trying to build the lesson locally.

github-actions[bot] commented 8 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-885

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md                                |    2 +-
 02-project-intro.md                                |    2 +-
 03-seeking-help.md                                 |    2 +-
 13-dplyr.md => 12-dplyr.md                         |    6 +-
 12-plyr.md (gone)                                  |  509 ----------
 14-tidyr.md => 13-tidyr.md                         |    0
 15-knitr-markdown.md => 14-knitr-markdown.md       |    2 +-
 16-wrap-up.md => 15-wrap-up.md                     |    0
 config.yaml (gone)                                 |   96 --
 ...ng => 12-dplyr-rendered-unnamed-chunk-27-1.png} |  Bin
 ...ng => 12-dplyr-rendered-unnamed-chunk-28-1.png} |  Bin
 ...ng => 12-dplyr-rendered-unnamed-chunk-29-1.png} |  Bin
 ...-knitr-markdown-rendered-rmd_to_html_fig-1.png} |  Bin
 md5sum.txt                                         |   51 +-
 reference.md                                       |   17 +-
 renv.lock (gone)                                   | 1043 --------------------
 16 files changed, 36 insertions(+), 1694 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-04-11 23:59:45 +0000

naupaka commented 8 months ago

I agree it's time to get this removed -- I am still wondering if there is a way to archive it or something. @tobyhodges is that something other lessons have done? If not, then I guess it is reasonable just to remove it and the references to it. I think it's reasonable to separate the removal of plyr and the request for a purrr lesson (which are both part of the discussion on #540).

tobyhodges commented 8 months ago

@naupaka we could archive it e.g. by relocating it to the More dropdown menu: making it somewhat similar to the extra episode available in the DC Image Processing curriculum. What would be the motivation for keeping it, as opposed to removing it from the lesson altogether? My interpretation of the discussion is that plyr has been retired, and the skills and concepts taught in the episode are covered sufficiently elsewhere.

Good point about the request for purrr in #540. If/when this is merged, perhaps we can open a new issue to track that aspect? Or keep #540 open but rename it and add a note that plyr has been removed?

milanmlft commented 8 months ago

Good point about the request for purrr in https://github.com/swcarpentry/r-novice-gapminder/issues/540. If/when this is merged, perhaps we can open a new issue to track that aspect? Or keep https://github.com/swcarpentry/r-novice-gapminder/issues/540 open but rename it and add a note that plyr has been removed?

I'd suggest creating a new issue for this. Currently this PR is set to close #540 when it gets merged in. That being said, I would argue that purrr is already a more advanced library and maybe not suitable for a novice R workshop? But that's just my view :) (I guess this is the sort of discussion that could be held in the new issue)

tobyhodges commented 7 months ago

I've opened the pleasingly-numbered #888 to provide a place for further discussion of the possibility to include an episode about purrr in the lesson.

@swcarpentry/r-novice-gapminder-maintainers is this ready to merge, or did you want to request something more from @milanmlft?

skanwal commented 6 months ago

Happy for this to be merged. Thanks @tobyhodges and @milanmlft

naupaka commented 6 months ago

Wow, end of an era. plyr, we knew ye well.

Thanks all!