swcarpentry / r-novice-inflammation

Programming with R
http://swcarpentry.github.io/r-novice-inflammation/
Other
163 stars 395 forks source link

Broken link to dataset: r-novice-inflammation-data.zip #377

Closed cdarabos closed 6 years ago

cdarabos commented 6 years ago

Link to dataset at the bottom of the page is broken: Download r-novice-inflammation-data.zip and move the file to this folder.

Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact Kate Hertweck (k8hertweck@gmail.com).


diyadas commented 6 years ago

Hello @cdarabos - thanks for your note!

@katrinleinweber I believe the broken link referred to is on this page: http://swcarpentry.github.io/r-novice-inflammation/setup/

It was accessible from that link as recently as June 12, so something has happened in the last 10 days or so.

katrinleinweber commented 6 years ago

Great minds think alike, and sometimes at the same time even on different continents :-D

diyadas commented 6 years ago

Thanks for resolving the issue so quickly :)

and thanks again @cdarabos for bringing this to our attention!

katrinleinweber commented 6 years ago

It might have been something in #373. In 6c59c895b238ad927e0571b3cedaf0f17e3782c6, the whole metadata block was removed, but I tested that here as well, and it didn't help. I'll git bisect it and report back.

katrinleinweber commented 6 years ago

Meh, doesn't work that easily. When bisect checks out a commit that was introduced by #373, the working dir is purged of all the r-novice files, so make serve runs into lots of missing file errors, and doesn't even progress to building the /setup and I thus can't even check where the link breaks.

I'm now merging 7400b93450253fadbb0ee1263bb950fb4ca4f06a into each checked-out state during bisecting.

cc @fmichonneau, @rgaiacs & @maxim-belkin: This might be interesting to you as well.

katrinleinweber commented 6 years ago

It seems that b2c0a4d4837ba582a9a46734904b376fea935906 triggered this bug, but probably in combination with setup.md@c02276f1 not having been prepared for the v9.3.0 style update, as r-novice-gapminder's setup.md was.

I'm not blaming anyone, maybe myself, but mostly the confusion during the first week of being a maintainer ;-)

maxim-belkin commented 6 years ago

Hmmm. The download link works for me

katrinleinweber commented 6 years ago

Before the two fixes c02276f17 fb976a45d3c3b288fba88437ebaa7b69360436d6 & https://github.com/swcarpentry/r-novice-inflammation/commit/18f6d4b578b8bac8b2ef764a9207a79fa68587da, see above.

Edit: correct hashes

maxim-belkin commented 6 years ago

um, with them, actually 😬

katrinleinweber commented 6 years ago

Does it work at git checkout c02276f17ef847299cf66932da6ec98defdc15d1?