swcarpentry / r-novice-inflammation

Programming with R
http://swcarpentry.github.io/r-novice-inflammation/
Other
163 stars 395 forks source link

Update 03-loops-R.Rmd #509

Closed choon-leng closed 1 year ago

choon-leng commented 3 years ago

for instructor checkout: suggest to add a diagram for "for loop"

Instructions Thanks for contributing! :heart: If this contribution is for instructor training, please email the link to this contribution to checkout@carpentries.org so we can record your progress. You've completed your contribution step for instructor checkout by submitting this contribution! Keep in mind that **lesson maintainers are volunteers** and it may take them some time to respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org. You may delete these instructions from your comment. \- The Carpentries
zkamvar commented 1 year ago

I'm helping the current lesson Maintainers process outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure.

Thank you for this contribution @sgichuki. We appreciate this figure diagramming a for loop, but because it does not have a higher resolution, it's an external resource, and it does not have alt text, I'm afraid it still needs a little more work before we can add it in. Because of this, I will be closing this PR without merging the change. I'm sorry for the delay in reviewing your contribution and hope that you will continue to contribute to The Carpentries lessons.