search

swcarpentry / r-novice-inflammation

Programming with R
http://swcarpentry.github.io/r-novice-inflammation/
Other
163 stars 395 forks source link

Add note about tests with NAs and is.na() #514

Closed Bisaloo closed 3 years ago

Bisaloo commented 3 years ago

Fix #511.

I'm happy to revisit this PR as much as needed. Please let me know if you see any possible improvements.

HaoZeke commented 3 years ago

Hi @Bisaloo, thanks so much for this! Looks great, and the examples are comprehensive and clear. However, I was wondering if you'd be willing to change from "You" to "We", for consistency with the rest of the lesson.

Bisaloo commented 3 years ago

Hi @HaoZeke, thanks for the feedback. It makes sense and I've updated this PR accordingly. There is still one 'you' at the very beginning because it's an actual 'you' in this case. Hope that's okay.

Please let me know if you see something else.

HaoZeke commented 3 years ago

Thanks for your contribution @Bisaloo!!