swcarpentry / shell-novice

The Unix Shell
http://swcarpentry.github.io/shell-novice/
Other
388 stars 974 forks source link

Formulate more clearly #1442

Closed cknuepfer closed 11 months ago

cknuepfer commented 11 months ago

A sentence was formulated more precisely.

The formulation "Next, we will assign a file name to the variable filename..." is misleading for two reasons:

  1. The assignment to $filename happens before the first step inside the loop.
  2. The assignment is not done by us, the users, but by the shell interpreter.
github-actions[bot] commented 11 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1442

The following changes were observed in the rendered markdown documents:

 05-loop.md | 3 +--
 md5sum.txt | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-11-09 07:51:16 +0000