search

swcarpentry / shell-novice

The Unix Shell
http://swcarpentry.github.io/shell-novice/
Other
373 stars 969 forks source link

Adding missing spaces between words #1445

Closed Volendor closed 6 months ago

Volendor commented 6 months ago

Small correction in .html: in some subheadings the words are stuck together.

Before: Screenshot from 2024-01-03 19-30-19

After: Screenshot from 2024-01-03 19-32-09

This is my very first pull request so I'm sorry if I did something wrong.

github-actions[bot] commented 6 months ago

:no_entry_sign: The gh-pages branch is no longer editable :no_entry_sign:

Thank you for your contribution. This lesson has migrated to use The Carpentries Workbench and the gh-pages branch is now automatically generated. This means in order to contribute, you will need to delete and re-fork this repository.

How to contribute

If you wish to contribute, you will need to use the following steps to delete, re-fork, and re-create your pull request (aka the burn it all down strategy):

  1. Save your edits on locally or in a scratch space.
  2. Delete your fork
  3. Create a new fork or use the "edit" button on the page you wish to edit.
  4. Apply your changes (NOTE The Workbench uses a different syntax. Here is a Transition Guide from Styles to Workbench for your reference).

    Questions

    If you have any questions or would like assistance, please contact @core-team-curriculum (curriculum@carpentries.org) or you can respond to this message.

bkmgit commented 6 months ago

Thanks. Markdown source https://github.com/swcarpentry/shell-novice/blob/main/episodes/02-filedir.md#exploring-more-ls-options seems ok - may need to figure out how to add extra space around rendered inline/code sections.

tobyhodges commented 6 months ago

Hi @Volendor thanks for reporting this problem and submitting the PR to fix it.

A Carpentries lesson site is built from source files in the main branch of a GitHub repository. These source files are written in a markup language called Markdown 1 (or, in some cases, R Markdown), which are then converted by some automated processes into the HTML files displayed by the web browser when someone visits the lesson 2. Those automatically-generated HTML files are stored in the gh-pages branch of the lesson repository.

Your pull request was closed automatically because you submitted changes made directly to one of the HTML files in the gh-pages branch. Any changes made to the files in this branch will be overwritten the next time the HTML files are rebuilt, and this automatic closure process prevents such changes from taking place. Instead, for your changes to be properly incorporated in the lesson site for the longer term, you would edit the relevant source Markdown file in the main branch.

However, as @bkmgit mentioned above, there is no obvious error in that Markdown source file (and indeed the current version looks ok when I build the HTML from source using my local installation of the lesson infrastructure) so I do not think this problem can be fixed here. Rather, it is an issue with the lesson infrastructure itself, occurring in other lessons as well as reported here: https://github.com/carpentries/sandpaper/issues/562