search

swcarpentry / shell-novice

The Unix Shell
http://swcarpentry.github.io/shell-novice/
Other
373 stars 969 forks source link

Clarify statement "the total count of each type of animal" in "Pipes and filters" challenge #1453

Open DaniMori opened 4 months ago

DaniMori commented 4 months ago

How could the content be improved?

Very minor improvement, but I'd like to suggest to correct this exercise statement (which led me to confusion while reading it for the first time):

https://github.com/swcarpentry/shell-novice/blob/f40c0b5e9582c3ec73cf5305784d272ec631367c/episodes/04-pipefilter.md#L604

My first impression was that what was being asked was, e.g. "the total number of deers, rabbits, etc." which, as understood from the naming of files and folders, could be "the sum of the last column, for each type of animal" (i.e. aggregating all the counts in all the dates).

Only after seeing the solution I noticed that it is "the total number of times each animal appears in the file" (that is, how many lines contain each animal type).

I'd suggest to change it to

-the total count of each type of animal in the file?
+how many times each type of animal appear in the file?

Which part of the content does your suggestion apply to?

https://github.com/swcarpentry/shell-novice/blob/main/episodes/04-pipefilter.md

bkmgit commented 3 months ago

@DaniMori Thanks for this. Will make the change, but you are also welcome to make a pull request.