search

swcarpentry / visualization-novice

Novice introduction to data visualization
https://swcarpentry.github.io/visualization-novice/
Other
1 stars 4 forks source link

what is the grammar of graphics implemented in ggplot2 #14

Closed nacmarino closed 7 years ago

nacmarino commented 7 years ago

I am creating this pull request to add information on one of the topics to be taugh in the lesson. This pull request is part of my instructor training checkout.

nacmarino commented 7 years ago

Thank you for the feedback @brymz! I only now realized the typos, sorry.

I just pushed an improved version of the content. Is it better?

aflaxman commented 7 years ago

@brymz : I have seen "Grammer of Graphics" attributed to Lee Wilkinson, who wrote a theory-of-viz book with that title: http://www.springer.com/us/book/9780387245447 If I have understood correctly, Hadley Wickham implemented Wilkinson's approach in ggplot.

nacmarino commented 7 years ago

Yes, this is correct! I believe that it would be more suitable to cite the work by Wilkinson here. How should we do it?

brymz commented 7 years ago

I think a link to the book or a related secondary (but accessible) site would do.

nacmarino commented 7 years ago

Here we go then! Link added.

brymz commented 7 years ago

Perfect.