search

swcarpentry / windows-installer

Software Carpentry installer for Windows.
MIT License
21 stars 17 forks source link

keep console open until user closes it #13

Closed benmarwick closed 10 years ago

benmarwick commented 10 years ago

Currently it all flashes by very fast the the user can't see what's happening. If we add os.system("pause") at the end the user can read the messages and then press any key to close the console. This is helpful because then the user can read where the new software has been installed, and easily find it to use it.

wking commented 10 years ago

On Thu, Jul 10, 2014 at 03:18:03PM -0700, Ben Marwick wrote:

Currently it all flashes by very fast the the user can't see what's happening.

I usually run the script from a terminal I open myself (instead of double-clicking). Then I can still see the output after the script exits, just like every other program (e.g. ‘ls’). For student use, the script will be packaged in an Inno installer 1. I don't have a Windows box to run the Inno installer myself, but I expect that any output-preservation should be happening there.

ethanwhite commented 10 years ago

I don't have a Windows box to run the Inno installer myself, but I expect that any output-preservation should be happening there.

The output isn't really preserved, but I think that's OK because the Inno installer is giving the proper queues that everything has finished (this was actually part of the original motivation for using a proper installer). I personally think that having the console stay open and require user input would be confusing in this context. @benmarwick can you take a look at the packaged behavior by running: http://files.software-carpentry.org/SWCarpentryInstaller.exe

and see what you think.

This is helpful because then the user can read where the new software has been installed, and easily find it to use it.

Everything should be ending up in the path so that it can be accessed from anywhere. Is there a particular use case you thinking of where having the exact location reported would be necessary?

benmarwick commented 10 years ago

I see, yes, thanks for the further explanation. Given those details I see now there's little value in having the install script messages persist on the screen. I've now tried the Inno installer and that works fine. I can see nano and sqlite3 working from the git bash prompt, so it seems to be working as intended.

ethanwhite commented 10 years ago

Thanks @benmarwick! We really appreciate both the testing and the feedback.

benmarwick commented 10 years ago

No worries, happy to help!