Closed wking closed 8 years ago
Is it truly necessary to be even this specific / strict in regexp? Why not just R-.*/bin
? Note: I know next to nothing about R and don't know if there are other paths we don't want that could conceivably match that regexp.
On Fri, Apr 15, 2016 at 05:23:07AM -0700, Erik Bray wrote:
Is it truly necessary to be even this specific / strict in regexp? Why not just
R-.*/bin
? Note: I know next to nothing about R and don't know if there are other paths we don't want that could conceivably match that regexp.
I'm in the same boat on R. A more relaxed regexp would probably be fine, but staying stricter means:
The downside is that we sometimes hit situations like #44. This is the first bump to that regexp since it landed in 58b7183ea (swc-windows-installer.py: Look for an R bin directory, 2014-06-09), so I don't think this is a high risk.
Yeah, looking again at your new regexp, it seems pretty unlikely to fail again, and pulling out the version number could be useful :)
@wking Do you have merge access on this repo?
On Mon, Jun 13, 2016 at 11:31:16AM -0700, Erik Bray wrote:
@wking Do you have merge access on this repo?
I do, but I don't like to merge my own PRs ;). If you don't, we should get it for you too.
I do, but I don't like to merge my own PRs ;).
Yep. same.
If you don't, we should get it for you too.
Please do!
On Mon, Jun 13, 2016 at 12:58:59PM -0700, Erik Bray wrote:
If you don't, we should get it for you too.
Please do!
@gvwilson, or other SWC admin: can we get write access to this repo for @embray?
Done!
On Thu, Apr 14, 2016 at 12:41:01PM -0700, Ethan White wrote:
Fixes #44.