search

swcarpentry / windows-installer

Software Carpentry installer for Windows.
MIT License
21 stars 17 forks source link

Installer no longer prints any information to terminal window that opens #8

Closed ethanwhite closed 10 years ago

ethanwhite commented 10 years ago

The installer used to print "Preparing your Software Carpentry awesomeness!" when it opened a terminal window during the install process. It no longer prints anything which has been confusing for users in the past. I suspect this has something to do with the fact that we are now using LOG.info('Preparing your Software Carpentry awesomeness!') and this not playing properly with the windows terminal window.

wking commented 10 years ago

On Wed, Jul 09, 2014 at 12:42:44AM -0700, Ethan White wrote:

The installer used to print "Preparing your Software Carpentry awesomeness!" when it opened a terminal window during the install process. It no longer prints anything which has been confusing for users in the past. I suspect this has something to do with the fact that we are now using LOG.info('Preparing your Software Carpentry awesomeness!') and this not playing properly with the windows terminal window.

Yup, the logging is set to ERROR by default, but all the current messages are either INFO- or DEBUG-level messages. To turn on medium logging (which should be appropriate for users), launch with:

$ swc-windows-installer.py --verbose info

To turn on debugging logging (appropriate for devs), launch with:

$ swc-windows-installer.py --verbose debug

ethanwhite commented 10 years ago

Thanks for the clarification. For the packaged version we want at least some indication that things are going on and I think that having all of the log info reported would be fine for this, but I readily know how to get the py2exe executable to run with arguments.

If we think that the info level of logging is the most common use case can we set info to be the default?

wking commented 10 years ago

On Wed, Jul 09, 2014 at 10:17:23AM -0700, Ethan White wrote:

If we think that the info level of logging is the most common use case can we set info to be the default?

Sure. How does #10 look to you?

wking commented 10 years ago

Fixed with #10 (I think ;).