search

swccgpc / holotable

Card Data Files for use with Holotable. Images used by Holotable, Gemp, and Scomp.
7 stars 8 forks source link

Image Filename Casing Strikes Back #144

Closed ronhowe closed 3 years ago

ronhowe commented 3 years ago

We had this issue last week.

The problem is that the t_e3pO.gif filename is conflicting with the t_e3po.gif filename. The large file is e3po.gif, all lowercase: https://github.com/swccgpc/holotable/tree/master/Images-HT/starwars/CloudCity-Dark/large

When the e3po images were added manually, the large file was generated as e3po.gif and the small file was generated as t_e3pO.gif. the GitHub actions automatically generate missing t_ files and commit them, so t_e3po.gif was missing and it was auto-created and committed.

Linux is a case insensitive filesystem, so it respects t_e3pO.gif and t_e3po.gif as different files. Windows is not case insensitive, so it believes the files as the same and overwrites them. That's why you see the change in git.

Really what needs to happen is for someone with a machine that honors filename case to remove the crusty filenames so the proper ones can be used.

Originally posted by @DevoKun in https://github.com/swccgpc/holotable/issues/126#issuecomment-789718370

It seems to have cropped up again with new new images.

ronhowe commented 3 years ago

image

ronhowe commented 3 years ago

Is there anything I can do on my Windows OS to deal with this? Nothing I do works except completely removing the folder and re-cloning the repo.

ronhowe commented 3 years ago

I submitted a PR to remove these.