search

swciitg / PortfolioBuilder

7 stars 48 forks source link

add-navbars-design #27

Closed Dhruv127 closed 1 year ago

Dhruv127 commented 1 year ago

creating separate files was making it complex, so as the ids in the navbars section were linked to the same preview page, I created the design there only. Please tell if I need to change the design or you can be specific about what you need.

deepak-2605 commented 1 year ago

All designs look very much similar. You can refer this site for designs . Create designs in seperate file. Pass this as prop where Code and Preview are called in PortfolioCard.jsx .Also, You need to update Code.js accordingly because user will need Code.js file to deploy the portfolio. Make sure that designs are responsive as well.

Dhruv127 commented 1 year ago

ok.. , how i can view preview section in full page?

deepak-2605 commented 1 year ago

ok.. , how i can view preview section in full page?

Right now , There is no simple way to view preview in full page. We are looking to forward to create an issue reagarding this. You can dowload Code part in Code.js file and run this as a seperate HTML file to view preview section in full page.

AnkitGurwan commented 1 year ago

@Dhruv127 we are not closing the issue. This commit was already there in your other PR, due to which it got merged. We are expecting different designs of navbars for this issue.