search

swciitg / PortfolioBuilder

5 stars 39 forks source link

Fix. Phone number validation and minor-bugs-2 #42

Closed DebidYadav closed 11 months ago

AnkitGurwan commented 11 months ago

We can't go on merging small commits each time. Can you remove some minor-bugs written in issue-minor-bugs2, that will hardly take 30 minutes. Will assign you that if you want?

DebidYadav commented 11 months ago

We can't go on merging small commits each time. Can you remove some minor-bugs written in issue-minor-bugs2, that will hardly take 30 minutes. Will assign you that if you want.

Can you merge this, for now, I'll take that one also, and assign it.

AnkitGurwan commented 11 months ago

Kindly add these changes in that issue/PR. Will merge that PR.

AnkitGurwan commented 11 months ago

Mention yourself in that issue, will assign you after that. Make the PR by today EOD as it's a beginner issue. We will assign to someone else otherwise.

AnkitGurwan commented 11 months ago

Login button is even bad than earlier. Project section styling is unchanged which was supposed to be done as per issue.

DebidYadav commented 11 months ago

Add specific instructions to how the button should be or attach any screenshots.

On Sat, Oct 21, 2023, 14:25 ANKIT GURWAN @.***> wrote:

Login button is even bad than earlier. Project section styling is unchanged which was supposed to be done as per issue.

— Reply to this email directly, view it on GitHub https://github.com/swciitg/PortfolioBuilder/pull/42#issuecomment-1773723356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKSOCJJHFUMSYDIDUHUEXLYAOEXJAVCNFSM6AAAAAA6APXDNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTG4ZDGMZVGY . You are receiving this because you authored the thread.Message ID: @.***>