swdotcom / swdc-vscode-musictime

A VS Code extension to discover the most productive music to listen to as you code
https://www.software.com/music-time
Apache License 2.0
560 stars 22 forks source link

Extension Host crashes with this extension loaded #29

Closed Chovin closed 3 years ago

Chovin commented 3 years ago

Describe the bug

extension host crashes when starting VSC with this extension enabled

ISSUE TYPE

Steps to reproduce

  1. Install this extension (or enabled if the extension is installed but disabled)
  2. Restart VSC
  3. Notice that Extension Host has crashed and no extensions work
  4. Disable the extension
  5. Restart VSC (or click Restart Extension Host)
  6. Notice that Extension Host doesn't crash and all other extensions work again

Expected behavior

extension works and extension host doesn't crash

ACTUAL RESULTS

extension host crashes

Screenshots

image

Desktop (please complete the following information):

Additional context

I have lots of VSC windows open, not sure if that might provide some insight.

Here's also a list of the extensions I have installed:

aaron-bond.better-comments
alefragnani.project-manager
auchenberg.vscode-browser-preview
christian-kohler.path-intellisense
CoenraadS.bracket-pair-colorizer
dbaeumer.vscode-eslint
eamodio.gitlens
EditorConfig.EditorConfig
eg2.vscode-npm-script
Equinusocio.vsc-material-theme
equinusocio.vsc-material-theme-icons
esbenp.prettier-vscode
formulahendry.auto-rename-tag
GitHub.vscode-pull-request-github
GrapeCity.gc-excelviewer
HookyQR.beautify
HookyQR.minify
hoovercj.vscode-power-mode
johnpapa.vscode-peacock
jsaulou.theme-by-language
karigari.chat
KnisterPeter.vscode-github
kruemelkatze.vscode-dashboard
lindraupe.aw-watcher-vscode
mechatroner.rainbow-csv
mhutchie.git-graph
ms-python.python
ms-vscode-remote.remote-containers
ms-vscode-remote.remote-wsl
ms-vscode.js-debug
ms-vscode.sublime-keybindings
ms-vsliveshare.vsliveshare
mtxr.sqltools
oderwat.indent-rainbow
p1c2u.docker-compose
PKief.material-icon-theme
pranaygp.vscode-css-peek
RandomFractalsInc.vscode-data-preview
ritwickdey.LiveServer
Shan.code-settings-sync
softwaredotcom.music-time
tomsaunders.vscode-workspace-explorer
unremarkable.pico8-simple-outline
vscode-icons-team.vscode-icons
vscode.configuration-editing
vscode.debug-auto-launch
vscode.emmet
vscode.extension-editing
vscode.git
vscode.json-language-features
vscode.merge-conflict
vscode.microsoft-authentication
vscode.npm
vscode.python
vscode.search-result
vscode.typescript-language-features
WallabyJs.quokka-vscode
yzhang.markdown-all-in-one
brettmstevens7 commented 3 years ago

Were you by chance able to capture an error in your dev tools console?

Chovin commented 3 years ago

I didn’t see any error other than extension host crashing and it giving me a list if extensions that were installed. Would you happen to know how to get a more detailed error?

FlavioAmurrioCS commented 3 years ago

I have encounter the same error. I used VS Code Extension Bisect to determine this extension was the cause. I thought it could have been because I am using vscode sync onto a this rebuilt machine and it logged me out, but even after logging in I get the error. I am using a Mac Air 2015 with Big Sur 11.1

VSCode Version: 1.52.1 Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523 Date: 2020-12-16T16:30:02.420Z (1 mo ago) Electron: 9.3.5 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Darwin x64 20.2.0

Not sure if the following is relevant but here you go. image

ghost commented 3 years ago

I also have an issue with this extension. Works fine most of the time, but when I install Ionide-fsharp for F# language support, this extension causes the extension host to crash.

[LineLens] Config Changed event
[LineLens] Installing
[LineLens] Installed
[PipelineHints] Config Changed event
[PipelineHints] Installing
[PipelineHints] Installed
[GitIgnore] gitignore path: c:\Users\jh\code\F#\test\.gitignore
[GitIgnore] Error accessing gitignore file [Error: ENOENT: no such file or directory, open
 'c:\Users\jh\code\F#\test\.gitignore'
    at Object.openSync (fs.js:466:3)
    at Object.func [as openSync] (electron/js2c/asar_bundle.js:5:1812)
    at Object.readFileSync (fs.js:368:35)
    at Object.e.readFileSync (electron/js2c/asar_bundle.js:5:8583)
    at Ru (c:\Users\jh\.vscode\extensions\ionide.ionide-fsharp-5.3.2\fsharp.js:2:490245)
        at c:\Users\jh\.vscode\extensions\ionide.ionide-fsharp-5.3.2\fsharp.js:2:490460
    at Object.then (c:\Users\jh\.vscode\extensions\ionide.ionide-fsharp-5.3.2\fsharp.js:1:54273)] {
  errno: -4058,
  syscall: 'open',
  code: 'ENOENT',
  path: 'c:\\Users\\jh\\code\\F#\\test\\.gitignore'
}
naquiroz commented 3 years ago

Can confirm this issue also occurs in vscode 1.54.1 macos.

mmclead commented 3 years ago

Thanks for the update and the error report. That's helpful

xavluiz commented 3 years ago

We have confirmed that the latest versions 2.1.14 and 2.1.16 have the fix for this issue, thank you.