search

swdyh / goodbye_chatwork

Chatwork(chatwork.com) log downloader
MIT License
67 stars 24 forks source link

Fix old_chat result order #23

Closed thatblue closed 6 years ago

thatblue commented 7 years ago

At first, thank you for your developing this awesome tools.

I changed a sort procedure to avoid loading duplicate messages. Message-ids are returned as string not integer, then negative operator (to reverse sort) of - i['id'] is not effected. This modification may resolve issue #22 .

I checked it on Windows7, ruby 2.4.1, and gem 2.6.11.

I am sorry but I am not good at Ruby, so if this modification is not a good Ruby's habit, please give me some feedback.

Regards,

hirokishirai commented 6 years ago

@thatblue Thank you for your great PR. I apologize for not getting back to you sooner. You are correct!

I wanna merge this PR. But circleci's test has not been starting. Mabye circleci.yml is bad. I'll merge this PR after I fix circleci.

Thanks!

hirokishirai commented 6 years ago

@thatblue Please commit empty commit with following command

git commit --allow-empty -m "hook of circleci test"
thatblue commented 6 years ago

@hirokishirai Thank you for reviewing! Also I apologize for could not immediately response.

I executed git commit --allow-empty -m "hook of circleci test" and pushed this commit, I am afraid that is not correct... Please notice if I did wrong operation.

hirokishirai commented 6 years ago

@thatblue I’m sorry I’m late! mmm...

I'll merge this PR with other PR!

hirokishirai commented 6 years ago

@thatblue I merged this PR with other PR(#26). Thank you for your greate PR!!