search

swe574-group2 / swe574

This repository is created for the course named "SWE 574 - Software Development as a Team".
5 stars 0 forks source link

UI for textual tags has several (varying) icons after creation #79

Closed uskudarli closed 7 years ago

uskudarli commented 7 years ago

I have seen this bug before. But it doesn't seem to an open bug.

I don't know what that icon is for? What to do with it? And, did you figure out why several duplications occur?

penumbram-zz commented 7 years ago

It was designed by the front-enders to indicate how many people annotated the text. For instance, if 3 different users annotate a text. It should show "3". If I remember correctly, the duplications were there at the presentation too, but I'm guessing nobody dared to debug. I'll try to fix it ASAP.

uskudarli commented 7 years ago

Right, it was like that in the demo also. I have not understood why sometimes it is 3 or 4. Could not reliably duplicate. It seems random, surely it is not.

@gr3ysky was imagining he may fix it... but probably did not dare as you said.

penumbram-zz commented 7 years ago

As you can see in the image below, it's fixed and now it's only showing 1 badge to indicate the number of annotations at a specific area. If you click on the red line boxing an annotation, It'll list the annotations in the CAT panel to the right. This one is showing the annotations I made for the term "societal demise".

screen shot 2017-01-07 at 20 28 28
uskudarli commented 7 years ago

Looks nice. But, when I visit that page I do not see any annotations. Neither annotations shows.

This is an interesting problem. I did not intentionally choose a nasty source. I thought it was an interesting blog to annotate.

Don't worry about it.

uskudarli commented 7 years ago

Did we conflate the problems of medium with the marks indicating number of annotations? If so sorry.

I think I need to update my plugin, sorry. Let me do that and test.

uskudarli commented 7 years ago

OK. Updated.

Now the extra icons don't appear. The number "1" stays constant. There is something off about what is being shown on the side. My observation is that the last annotation created doesn't show up on the list.

I have 4 annotations on our puppies test page. (not giving full link here, but you know it)

penumbram-zz commented 7 years ago

@uskudarli I think I understand what you mean, I'll investigate further.

penumbram-zz commented 7 years ago

Before the commit above, it wasn't possible to update a badge (the number of annotations for a target selector shown in the bottom right). Now it looks okay, though It's hard call it a minor issue, since it had its roots in 2 different realms of problem. First, once shown, the changed html wasn't open to update, and that was a deal breaker for updating "1" to "2". Second, an AJAX call was being treated as if it was a synchronous call, which is never the case with AJAX (AJAX calls are by definition async).

Apart from that, I found out that "abc" and "abc " were treated differently. Which was causing a UX issue since it's quite likely for a user to select the whitespace before or after a word. Looks like it's fixed now, the whitespace is trimmed at the time of insertion and the selector's start-end indexes are updated accordingly.

penumbram-zz commented 7 years ago

@uskudarli I believe this is resolved, isn't it? Is there anything to improve? If not, shall we close this last issue?

uskudarli commented 7 years ago

Yes, it is. Thank you.

penumbram-zz commented 7 years ago

@uskudarli Before you go, how about we set up a social for a coffee/drink to celebrate the end of our project?

What do you say? @gr3ysky @ardaofluoglu @okanmenevseoglu @seydakaradag @skanca Maybe group 1 would like to join too?

uskudarli commented 7 years ago

Go where? :) I am always here.

Sure. After grades submission, would be my pleasure.

gr3ysky commented 7 years ago

I can join :)