search

swe574-spring23 / SWE574

BOUN Spring 574 Project
MIT License
0 stars 0 forks source link

DEV | Fix space_initial.html #81

Closed cemrekut closed 1 year ago

cemrekut commented 1 year ago

@ceydaduzgec Ceyda i add some features in recommendation space. But i can't send it. Can you help me

ceydaduzgec commented 1 year ago

Sure thing! There were some things missing. 1- There were conflicts between dev and your branch. I resolved it but I can show you how to resolve it on your own in our next meeting. 2- The name of the pull request should start with the branch you want to merge into. In our case it is dev so the name of the pull request should be: DEV | Feature specifics 3- You should always assign reviewer and assignee. 4- Also adding label, project and milestone is a good practice. 5- Lastly, you should make sure that the github checks are passed. For linter you can read more on -> docs/linting.md

cemrekut commented 1 year ago

thank you so much