sweatco / react-native-code-push-diff

MIT License
4 stars 0 forks source link

Hermes Enabled iOS #11

Open cris7hian30-df opened 3 weeks ago

cris7hian30-df commented 3 weeks ago

I have enabled Hermes in my app, but I have not updated to the new architecture, and the Code Push Diff builds install but do not make changes, do you know what it could be? or if it is necessary to enable also the new architecture.

System: OS: macOS 14.5 CPU: (10) arm64 Apple M1 Pro Memory: 97.73 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 18.17.0 path: /var/folders/tp/txs1qj590jbgnz3bc0r7j09c0000gp/T/yarn--1730246161950-0.3785886425488276/node Yarn: version: 1.22.19 path: /var/folders/tp/txs1qj590jbgnz3bc0r7j09c0000gp/T/yarn--1730246161950-0.3785886425488276/yarn npm: version: 9.6.7 path: /usr/local/bin/npm Watchman: version: 2024.10.07.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /usr/local/bin/pod SDKs: iOS SDK: Platforms:

gerdigitalfemsa commented 3 weeks ago

x2 @Augustach could you help us bro.

Augustach commented 3 weeks ago

It should work, and it does on the old architecture. Do you not see changes in assets or the js code? You also can compare the example with your project.

gerdigitalfemsa commented 3 weeks ago

@Augustach the apps begin freeze after de update of bundle, i cannnot do anything on the app frezzeed.

cris7hian30-df commented 3 weeks ago

It should work, and it does on the old architecture. Do you not see changes in assets or the js code? You also can compare the example with your project.

The app freezes after the update, I am comparing the example with my project and the only thing different is the version of RN and CodePush.

Augustach commented 2 weeks ago

There is a standard example React Native app created using the npx @react-native-community/cli init CodePushDiff72Issue --version 0.72.14 command.

Then I created a codepush bundle via yarn code-push-diff release-react --app <app_name> --base main --npm yarn -d Staging and launch the release version of app.

It works fine for the example app with 0.72.14 react-native.

Could you please try creating a new CodePush bundle using the code-push-diff command? If it still doesn’t work, could you also try creating the CodePush bundle viaappcenter-cli?

Augustach commented 2 weeks ago

I’d like to help, but I’ll need an example app or clear steps to reproduce the issue to proceed.

Augustach commented 6 days ago

Hey @cris7hian30-df @gerdigitalfemsa

Were you able to resolve the issue?