sweble / sweble-wikitext

The Sweble Wikitext Components module provides a parser for MediaWiki's wikitext and an engine trying to emulate the behavior of a MediaWiki.
http://sweble.org/sites/swc-devel/develop-latest/tooling/sweble/sweble-wikitext
70 stars 27 forks source link

Modernize project and make it buildable #91

Closed rzo1 closed 6 months ago

rzo1 commented 11 months ago

What does this PR do?

I checked out the repository to work on https://github.com/sweble/sweble-wikitext/issues/90 and wasn't able to build the project due to different issues.

Therefore, I went ahead to fix them:

wetneb commented 6 months ago

I guess all we need to merge this is just to get the CI to pass, no?

rzo1 commented 6 months ago

The CI failed with something unrelated afair. Maybe you can retrigger?

wetneb commented 6 months ago

I don't have the option to re-trigger, perhaps because the last build is too old. Could you perhaps make a tiny irrelevant change? :-D

rzo1 commented 6 months ago

@wetneb Can you approve the workflow? ;-)

rzo1 commented 6 months ago

Great. Don't think that

Caused by: org.eclipse.jgit.errors.RevWalkException: Walk failure.
    at org.eclipse.jgit.revwalk.RevWalk.iterator(RevWalk.java:1259)
    at pl.project13.jgit.DescribeCommand.findCommitsUntilSomeTag(DescribeCommand.java:404)
    ... 32 more
Caused by: org.eclipse.jgit.errors.MissingObjectException: Missing commit 721db2b0560630faa0ae9e7693c800fc9e8dcd54
    at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:149)
    at org.eclipse.jgit.revwalk.RevWalk.getCachedBytes(RevWalk.java:883)
    at org.eclipse.jgit.revwalk.RevCommit.parseHeaders(RevCommit.java:145)
    at org.eclipse.jgit.revwalk.PendingGenerator.next(PendingGenerator.java:[148](https://github.com/sweble/sweble-wikitext/actions/runs/8642953682/job/23695614231#step:5:149))
    at org.eclipse.jgit.revwalk.StartGenerator.next(StartGenerator.java:183)
    at org.eclipse.jgit.revwalk.RevWalk.next(RevWalk.java:421)
    at org.eclipse.jgit.revwalk.RevWalk.iterator(RevWalk.java:1257)
    ... 33 more

is actually related.

wetneb commented 6 months ago

I do think it is related: you have removed fetch-depth: 0 from the git cloning options in the CI. Can you try adding it back?

rzo1 commented 6 months ago

@wetneb thanks for the hint, seems to work now

mawiesne commented 6 months ago

Thx @wetneb