search

swecc-uw / swecc-website

Software Engineering Career Club Website
https://swecc.org
4 stars 29 forks source link

Don't spam the dark mode switch #45

Closed wkxdavid closed 2 months ago

wkxdavid commented 3 months ago

Is your feature request related to a problem? Please describe. This is an fun feature. There is no direct bug or issue, just a fun game easter egg.

Describe the solution you'd like When the dark and light mode switch has been clicked 10 times, display a small pop up message that makes a joke.

Additional context The joke can be anything or it can cycle. Potentially, if you keep clicking it after the message, it will start getting more annoyed or mad? May need design depending on how and where the message will be displayed. image

RandolphTang commented 2 months ago

hello, I just wonder if this issue still unresolved, I would be love to help with it. @shiinasugi

wkxdavid commented 2 months ago

@shiinasugi

I don't believe anyone has done this feature yet.

shiinasugioka commented 2 months ago

@RandolphTang Assigned! Also my github is @shiinasugioka haha

RandolphTang commented 2 months ago

@shiinasugioka hello Shiina, I also finished the Don't spam the dark mode switch issue, and the new commit is called "Don't spam the dark mode switch 4/13." I don't know why the page always directs me to the front page background image issue when I open pull request, so just letting you know here.

shiinasugioka commented 2 months ago

@RandolphTang Thank you, I’ll take a look by the end of the day. Feel free to pick up new issues while you wait

shiinasugioka commented 2 months ago

@RandolphTang Can you share a link to the PR? I don't see it

RandolphTang commented 2 months ago

@shiinasugioka Oh I think it was accidentally committed to the front page title pull request https://github.com/swecc-uw/swecc-website/pull/88#pullrequestreview-1999339859 (the last 3 commit were the Don't spam the dark mode switch), I thought I mentioned that in a previous comment.

Sorry for the inconvenience.

shiinasugioka commented 2 months ago

@RandolphTang Oh I see what happened. I recommend you use a different branch for each issue you're working on. The pull request merged changed from your Don't spam issue as well as both the issues were on the main branch. That's my bad for not noticing, but it also looks like the dark mode switch is working fine. Great job!