swedenconnect / signservice

A signature service according to the Swedish eID Framework specifications
Apache License 2.0
4 stars 1 forks source link

SADValidator as interface? #149

Closed Razumain closed 1 year ago

Razumain commented 1 year ago

SwedenConnectSamlAuthenticationHandler has a setter for SADValidator that allows setting a custom SADValidator.

If no one is set, the SADValidator of se.swedenconnect.opensaml.sweid.saml2.signservice.SADParser.SADValidator is set.

The problem here is that SADValidator is not an interface, but rather a static sub-class of SADParser, making it very hard to provide a custom implementation of it as intended by SwedenConnectSamlAuthenticationHandler

This seems to be a logical mismatch.

martin-lindstrom commented 1 year ago

Moving