Sweep: improve cleanAccount stored procedure to accept a list of accounts

Here's the PR! https://github.com/sweepai-dev/killbill/pull/4.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have 48 GPT-4 tickets left.To get Sweep to recreate this ticket, leave a comment prefixed with "sweep:" or edit the issue.

Install Sweep Configs: Pull Request

Step 1: 🔍 Code Search

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/sweepai-dev/killbill/blob/b3c3a462ad2f44273126d1bb5c6b4775eae1f8ad/account/src/main/resources/org/killbill/billing/account/dao/AccountSqlDao.sql.stg#L1-L109 https://github.com/sweepai-dev/killbill/blob/b3c3a462ad2f44273126d1bb5c6b4775eae1f8ad/account/src/main/resources/org/killbill/billing/account/ddl.sql#L1-L120 https://github.com/sweepai-dev/killbill/blob/b3c3a462ad2f44273126d1bb5c6b4775eae1f8ad/util/src/main/resources/org/killbill/billing/util/entity/dao/EntitySqlDao.sql.stg#L1-L62 https://github.com/sweepai-dev/killbill/blob/b3c3a462ad2f44273126d1bb5c6b4775eae1f8ad/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestWithInvoiceHardening.java#L172-L274 https://github.com/sweepai-dev/killbill/blob/b3c3a462ad2f44273126d1bb5c6b4775eae1f8ad/util/src/main/resources/org/killbill/billing/util/entity/dao/EntitySqlDao.sql.stg#L388-L509

I also found the following external resources that might be helpful:

Summaries of links found in the content:

https://github.com/pierre/killbill/blob/master/util/src/main/resources/cleanAccount.sql:

The page does not contain any relevant content or code snippets.

Step 2: 🧐 Snippet Analysis

From looking through the relevant snippets, I decided to make the following modifications:

File Path	Proposed Changes
`util/src/main/resources/cleanAccount.sql`	Modify the `cleanAccount` stored procedure to accept a list of account IDs. Add a loop to iterate over the list of account IDs and perform the deletion operation for each one. Include error handling to manage potential issues such as an empty list or non-existent account IDs.

Step 3: 📝 Planning

I have created a plan for writing the pull request. I am now working my plan and coding the required changes to address this issue. Here is the planned pull request:

Improve cleanAccount stored procedure to accept a list of accounts sweep/cleanAccount-multiple-accounts

Description

This PR modifies the cleanAccount stored procedure in the cleanAccount.sql file to accept a list of account IDs instead of a single account ID. The current procedure only allows for deletion of one account at a time, which is not efficient when multiple accounts need to be deleted.

The modification includes adding a loop to iterate over the list of account IDs and perform the deletion operation for each one. Error handling is also added to handle potential issues such as an empty list or non-existent account IDs.

Summary of Changes

Modified the cleanAccount stored procedure in cleanAccount.sql to accept a list of account IDs.

Added a loop to iterate over the list of account IDs and perform the deletion operation for each one.

Implemented error handling to manage potential issues such as an empty list or non-existent account IDs.

Ensured the code is formatted correctly and follows the existing code style.

Please review the changes and let me know if any further modifications are required.

Step 4: ⌨️ Coding

I have finished coding the issue. I am now reviewing it for completeness.

Step 5: 🔁 Code Review

Success! 🚀

To recreate the pull request, leave a comment prefixed with "sweep:" or edit the issue. ^{Join Our Discord}

sweepai-dev / killbill