sweepai / evals

Apache License 2.0
0 stars 0 forks source link

Sweep: refactor the training loop from a script to a class in main.py #6

Open wwzeng1 opened 1 year ago

wwzeng1 commented 1 year ago

Details

No response

Checklist - [X] Modify `src/main.py` ✓ https://github.com/sweepai/evals/commit/35f37cdbd49a63bfdd7a39e2d65b0c186ad83c49 - [X] Ran sandbox for `src/main.py`. ✓ https://github.com/sweepai/evals/commit/52cb808b1b8bc91787d586dd565b782319ec01c4 - [X] Modify `src/api.py` ✓ https://github.com/sweepai/evals/commit/c1333ece180d5e2412e2ec2e2d68d752b38fbdc0 - [X] Ran sandbox for `src/api.py`. ✓ https://github.com/sweepai/evals/commit/b31fc724747dc0cd6fdae265be435aa36b06ab4a ![Flowchart](https://raw.githubusercontent.com/sweepai/evals/sweep/assets/6f7f05ba17676da289c0cab99123ff9d69555e359d883270e42188092eb9b11d_6_flowchart.svg)
sweep-nightly[bot] commented 1 year ago

Here's the PR! https://github.com/sweepai/evals/pull/163.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: c863ad18ba)

Actions (click)

Sandbox Execution ✓

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for 7284908
trunk fmt src/main.py || exit 0 1/2 ✓
  NOTICES  
 src/main.py  ignored empty file [black]
 Hint: use --force to check ignored files
Checked 1 file
✔ No issues
trunk check --fix --filter=-ruff --print-failures src/main.py 2/2 ✓
  NOTICES  
 src/main.py  ignored empty file [black]
 Hint: use --force to check ignored files
Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/sweepai/evals/blob/72849082ab1fcf90323a2d3b20d400de0d41ebd9/src/main.py#L1-L46 https://github.com/sweepai/evals/blob/72849082ab1fcf90323a2d3b20d400de0d41ebd9/src/api.py#L1-L27 https://github.com/sweepai/evals/blob/72849082ab1fcf90323a2d3b20d400de0d41ebd9/requirements.txt#L1-L15

Step 2: ⌨️ Coding

trunk fmt src/main.py || exit 0 1/2 ✓
 ✔ Formatted src/main.py
Re-checking autofixed files...

Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
trunk check --fix --filter=-ruff --print-failures src/main.py 2/2 ✓
Checked 1 file
✔ No issues

trunk fmt src/api.py || exit 0 1/2 ✓
 ✔ Formatted src/api.py
Re-checking autofixed files...

 ✔ Formatted src/api.py
Re-checking autofixed files...

Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
trunk check --fix --filter=-ruff --print-failures src/api.py 2/2 ✓
Checked 1 file
✔ No issues


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/refactor-training-loop_27.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord