Sweep: Move the payment_message and payment_message_start creation logic out of on_ticket.py into a separate function at the end of the file

Here's the PR! https://github.com/sweepai/sweep/pull/2646.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 85c128d70e)

Actions (click)

[ ] ↻ Restart Sweep

Sandbox Execution ✓

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for eb2aaa5

git add . && pre-commit run --files sweepai/handlers/on_ticket.py || exit 0 1/3 ✓
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
black....................................................................Passed
isort....................................................................Passed
autoflake................................................................Passed
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run pylint --errors-only sweepai/handlers/on_ticket.py; else exit 0; fi 2/3 ✓
(nothing was outputted)
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run python sweepai/handlers/on_ticket.py; else exit 0; fi 3/3 ✓
(nothing was outputted)

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/sweepai/sweep/blob/eb2aaa5f24af02dd18432464e5a36f02213ae6ed/sweepai/handlers/on_ticket.py#L404-L414 https://github.com/sweepai/sweep/blob/eb2aaa5f24af02dd18432464e5a36f02213ae6ed/sweepai/handlers/on_ticket.py#L1339-L1354

Step 2: ⌨️ Coding

[X] Modify sweepai/handlers/on_ticket.py ✓ https://github.com/sweepai/sweep/commit/84b68ba15f0fae6745e97d9080a99384202a55bf

Modify sweepai/handlers/on_ticket.py with contents:
• At the end of the `on_ticket.py` file, add a new function named `create_payment_messages`. This function should take the following parameters: `user_type`, `model_name`, `gpt_tickets_left_message`, `daily_message`, `tracking_id`, `is_paying_user`, `single_payment_link`, and `pro_payment_link`.
• Inside the `create_payment_messages` function, move the logic for creating `payment_message` and `payment_message_start` from lines 404-413. The function should return `payment_message` and `payment_message_start`.
• Replace the inline logic for creating `payment_message` and `payment_message_start` on lines 404-413 with a call to the `create_payment_messages` function. Pass the necessary parameters to the function and assign the returned values to `payment_message` and `payment_message_start`.
• Ensure that the `create_payment_messages` function is called before it is used on line 1350. Replace the inline logic on line 1350 with the appropriate variable that holds the return value from the `create_payment_messages` function.
[X] Ran sandbox for sweepai/handlers/on_ticket.py. ✓ https://github.com/sweepai/sweep/commit/b37a5b6dd9d27b9cd1666ee112524baf401b0c23

Sandbox logs for https://github.com/sweepai/sweep/commit/b37a5b6dd9d27b9cd1666ee112524baf401b0c23

git add . && pre-commit run --files sweepai/handlers/on_ticket.py || exit 0 1/3 ✓
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
black....................................................................Failed
- hook id: black
- files were modified by this hook
reformatted sweepai/handlers/on_ticket.py
All done! ✨ 🍰 ✨
1 file reformatted.
isort....................................................................Passed
autoflake................................................................Passed
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run pylint --errors-only sweepai/handlers/on_ticket.py; else exit 0; fi 2/3 ✓
(nothing was outputted)
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run python sweepai/handlers/on_ticket.py; else exit 0; fi 3/3 ✓
2023-11-28 07:16:14.994 | INFO     | sweepai.config.server::196 - No Sandbox URL found.

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/refactor-payment-message-creation_4.

🎉 Latest improvements to Sweep:

Sweep uses OpenAI's latest Assistant API to plan code changes and modify code! This is 3x faster and significantly more reliable as it allows Sweep to edit code and validate the changes in tight iterations, the same way as a human would.
Sweep now uses the rope library to refactor Python! Check out Large Language Models are Bad at Refactoring Code. To have Sweep refactor your code, try sweep: Refactor <your_file>.py!

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. ^{Join Our Discord}

sweepai / sweep