Sweep: Refactor on_ticket.py to be more modular.

Here's the PR! https://github.com/sweepai/sweep/pull/2611.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 9e48b3b566)

Actions (click)

[ ] ↻ Restart Sweep

Sandbox Execution ✓

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for 81c3ac4

git add . && pre-commit run --files sweepai/handlers/on_ticket.py || exit 0 1/6 ✓
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
black....................................................................Passed
isort....................................................................Passed
autoflake................................................................Passed
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run pylint --errors-only sweepai/handlers/on_ticket.py; else exit 0; fi 2/6 ✓
(nothing was outputted)
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run python sweepai/handlers/on_ticket.py; else exit 0; fi 3/6 ✓
2023-11-19 02:20:40.838 | INFO     | sweepai.config.server::197 - No Sandbox URL found.
git add . && pre-commit run --files sweepai/handlers/on_ticket.py || exit 0 4/6 ✓
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
black....................................................................Passed
isort....................................................................Passed
autoflake................................................................Passed
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run pylint --errors-only sweepai/handlers/on_ticket.py; else exit 0; fi 5/6 ✓
(nothing was outputted)
if [[ "sweepai/handlers/on_ticket.py" == *.py ]]; then PYTHONPATH=. poetry run python sweepai/handlers/on_ticket.py; else exit 0; fi 6/6 ✓
(nothing was outputted)

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/sweepai/sweep/blob/81c3ac419670188fbd9bc400590cb8e589596297/sweepai/handlers/on_ticket.py#L948-L1028

Step 2: ⌨️ Coding

[X] Refactor sweepai/handlers/on_ticket.py ✓ https://github.com/sweepai/sweep/commit/e2533cab009f58b149b7cb2ff26d9f8e990b2fc1

Refactor sweepai/handlers/on_ticket.py with contents:
• Extract the logic for fetching files into a new function named `fetch_files` in the on_ticket_utils.py module. This function should take the same arguments as the current function and return the same results.
• Extract the logic for validating file change requests into a new function named `validate_file_change_requests` in the on_ticket_utils.py module. This function should take the same arguments as the current function and return the same results.
• Extract the logic for generating pull requests into a new function named `generate_pull_request` in the on_ticket_utils.py module. This function should take the same arguments as the current function and return the same results.
[X] Modify sweepai/handlers/on_ticket.py ✓ https://github.com/sweepai/sweep/commit/83dfef50b6b0881c255653cb4f27449bb09a8917

Modify sweepai/handlers/on_ticket.py with contents: Add detailed, sphinx-style docstrings to all of the new functions.
[X] Test sweepai/handlers/on_ticket_utils_test.py ✗

Test sweepai/handlers/on_ticket_utils_test.py with contents:
• Unit tests for `fetch_files` function in on_ticket_utils.py, to be written in on_ticket_utils_test.py. The tests should cover all possible scenarios including but not limited to: when the file paths are valid, when the file paths are invalid, and when there are no file paths.
• Unit tests for `validate_file_change_requests` function in on_ticket_utils.py, to be written in on_ticket_utils_test.py. The tests should cover all possible scenarios including but not limited to: when the file change requests are valid, when the file change requests are invalid, and when there are no file change requests.
• Unit tests for `generate_pull_request` function in on_ticket_utils.py, to be written in on_ticket_utils_test.py. The tests should cover all possible scenarios including but not limited to: when the pull request generation is successful, when the pull request generation fails, and when there are no changes to generate a pull request.
[X] Ran sandbox for sweepai/handlers/on_ticket_utils_test.py. ✗

Run `sweepai/handlers/on_ticket_utils_test.py` through the sandbox.

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/on_ticket_modularity_7.

🎉 Latest improvements to Sweep:

Sweep now uses the rope library to refactor Python! Check out Large Language Models are Bad at Refactoring Code. To have Sweep refactor your code, try sweep: Refactor <your_file>.py!
Sweep finds and fixes bugs in your code by writing unit tests! Check out Having GPT-4 Iterate on Unit Tests like a Human.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. ^{Join Our Discord}

sweepai / sweep