sweetalert2 / ngx-sweetalert2

Declarative, reactive, and template-driven SweetAlert2 integration for Angular
MIT License
657 stars 95 forks source link

Support for Angular 17 #255

Closed jandeu closed 8 months ago

jandeu commented 11 months ago

Please update dependencies to support Angular 17

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^14.0.0 || ^15.0.0 || ^16.0.0" from @sweetalert2/ngx-sweetalert2@12.2.0
npm ERR! node_modules/@sweetalert2/ngx-sweetalert2
npm ERR!   @sweetalert2/ngx-sweetalert2@"^12.2.0" from the root project
jandeu commented 11 months ago

There is already opened PR https://github.com/sweetalert2/ngx-sweetalert2/pull/252

ivanvastag commented 11 months ago

Will this get merged any time soon?

FGO-LPCR commented 10 months ago

Any news on this issue? @limonte @toverux @zenflow

D-Biela commented 10 months ago

Any news?

DanielInova commented 9 months ago

My company will stop using sweetalert because of the horrible repo-/ code-management. Every major angular-version we had to wait for weeks for an update, which mostly involved changing one digit to match the current angular-version...

Lucasrsv1 commented 9 months ago

Until the PR is merged, we can workaround this error by adding the following override to package.json:

"overrides": {
    "@sweetalert2/ngx-sweetalert2": {
        "@angular/common": "^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0",
        "@angular/core": "^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0"
    }
}

I hope this helps.

limonte commented 8 months ago

:tada: This issue is solved in version 12.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: