chore: fix "lint" script & add "lint-fix" script

sweetalert2 / sweetalert2-react-content

Official SweetAlert2 enhancer adding support for React elements as content

MIT License

689 stars 47 forks source link

chore: fix "lint" script & add "lint-fix" script #212

Closed zenflow closed 1 year ago

zenflow commented 1 year ago

Fixes:

Windows compatibility
cover more files (e.g. files in cypress dir & root dir)

limonte commented 1 year ago

Are you maybe planning to tackle #192? I also have it on my todo list, TBH I didn't like the quality of the code in the external PR.

zenflow commented 1 year ago

@limonte yeah, I found the logic hard to follow. I reviewed again yesterday and still do. I think it's inherently complicated, but also I think it could probably be improved. Would need to wrap my head around it first lol.

It's on my todo list as well but not sure when I'll get to it, so go ahead if you find time before me.

I made a PR to add tests, could use your review: https://github.com/omerman/sweetalert2-react-content/pull/1

limonte commented 1 year ago

:tada: This PR is included in version 5.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: