search

sweetalert2 / sweetalert2-themes

Themes for SweetAlert2: Dark, Minimal, Borderless, Bootstrap, Material UI, WordPress Admin, Bulma, ...
MIT License
221 stars 92 forks source link

Bootstrap 4 Theme CSS Values alignment #73

Open GeoSot opened 3 years ago

GeoSot commented 3 years ago

New feature motivation

Trying ti adopt the bootstrap theme into my app, I realized that scss is initialized using the default bootstrap values and not these given from bootstrap's variables file. So It can't follow any bootstrap customization

New feature description

It could be possible to align variables with bootstrap scss variables (select2 themes applies this method). just to include the following before build 

@import "~bootstrap/scss/functions";
@import "~bootstrap/scss/variables";
@import "~bootstrap/scss/mixins";

and change the fixed values of the following lines to the proper variables https://github.com/sweetalert2/sweetalert2-themes/blob/1667812b63936752e9864496dcd81ee40bdc2c59/bootstrap-4/bootstrap-4.scss#L16-L135

PS: If you like , could help on this

limonte commented 3 years ago

I would really appreciate your help @GeoSot, thanks for reporting! Let me know if you have any questions about contributing.