search

sweetlilmre / TapuinoNext

The evolution of the Tapuino project
Other
22 stars 7 forks source link

name->path mismatch and file filter add on #6

Closed predecker closed 2 years ago

predecker commented 2 years ago

here's my issue as a pull request.

Now the jump one directory up in the file selection at "Insert tap" should work.

And I learn to use GitHub. :-)

ok, and I learn, that an open pull request collects all newer changes I do. So I have to expand this comment.

MacOS puts nasty hidden files on every filesystem it get's its hands on. They start with a "." and annoyed me in the file selector. So I expanded your filter a bit.

sweetlilmre commented 2 years ago

Hi,

Thanks for the PR! This looks good and passes CI so is probably good to go. I'll only be able to merge it in a day or 2 as I am away for the weekend. For future PRs can you make them on a branch off of main? In this way the auto version script won't get triggered and change the version files :) It's not a major issue as I'll be overwriting them when I merge my next PR in.

predecker commented 2 years ago

that delete action does not feel correct. I think, I'll start a new pull request and close this. Stay tuned. :-)

sweetlilmre commented 2 years ago

Your changes are live in the latest release. I haven't had a chance to test but should be good. (I merged in some of my changes, which I did test). I'll give it a go when I get home tonight.

Thanks -(e)

On Tue, 21 Jun 2022 at 16:38, predecker @.***> wrote:

that delete action does not feel correct. I think, I'll start a new pull request and close this. Stay tuned. :-)

— Reply to this email directly, view it on GitHub https://github.com/sweetlilmre/TapuinoNext/pull/6#issuecomment-1161836995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFFGOSZS6EBWEXNIBHQK3VQHHWLANCNFSM5Y6SWGVA . You are receiving this because you commented.Message ID: @.***>